-
Notifications
You must be signed in to change notification settings - Fork 831
feat(core/ui) : allow user to change transaction page into local language #3132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from 2 commits
7a43024
c2faf6b
2f3e82e
0cd7f9a
97228af
724fd29
341d683
521b080
45fad3e
0a9b097
d0fac04
5fd85df
1e53440
137f1e3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,7 @@ fun LoanTransactionDetailsResponseDto.toModel(): TransactionDetails { | |
| return TransactionDetails( | ||
| id = this.id ?: -1L, | ||
| transactionName = type?.value ?: "Loan Transaction", | ||
| typeCode = type?.code, | ||
|
Aditya002500 marked this conversation as resolved.
Outdated
|
||
| isCredit = isCreditResolved, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. here also this pr scope should not other other things than adding translation strings .
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The strings were missing so I simply added those |
||
| amount = this.amount ?: 0.0, | ||
| currencyCode = this.currency?.code ?: "USD", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,7 @@ data class TransactionDetails( | |
|
|
||
| val id: Long, | ||
| val transactionName: String, | ||
| val typeCode: String? = null, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this be removed as well? Please review. |
||
| val isCredit: Boolean, | ||
| val amount: Double, | ||
| val currencyCode: String, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -124,4 +124,51 @@ | |
| <string name="feature_savings_filter">الفلاتر</string> | ||
| <string name="feature_savings_reset">إعادة تعيين</string> | ||
| <string name="feature_savings_apply">تطبيق</string> | ||
|
|
||
| <string name="tx_date_today">اليوم</string> | ||
| <string name="tx_date_yesterday">أمس</string> | ||
|
|
||
| <string name="tx_month_jan">يناير</string> | ||
| <string name="tx_month_feb">فبراير</string> | ||
| <string name="tx_month_mar">مارس</string> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please follow proper naming of string resources. |
||
| <string name="tx_month_apr">أبريل</string> | ||
| <string name="tx_month_may">مايو</string> | ||
| <string name="tx_month_jun">يونيو</string> | ||
| <string name="tx_month_jul">يوليو</string> | ||
| <string name="tx_month_aug">أغسطس</string> | ||
| <string name="tx_month_sep">سبتمبر</string> | ||
| <string name="tx_month_oct">أكتوبر</string> | ||
| <string name="tx_month_nov">نوفمبر</string> | ||
| <string name="tx_month_dec">ديسمبر</string> | ||
|
|
||
| <string name="tx_type_deposit">إيداع</string> | ||
| <string name="tx_type_withdrawal">سحب</string> | ||
| <string name="tx_type_interest_posting">تقييد الفائدة</string> | ||
| <string name="tx_type_fee_deduction">خصم الرسوم</string> | ||
| <string name="tx_type_initiate_transfer">بدء التحويل</string> | ||
| <string name="tx_type_approve_transfer">موافقة على التحويل</string> | ||
| <string name="tx_type_withdraw_transfer">سحب التحويل</string> | ||
| <string name="tx_type_reject_transfer">رفض التحويل</string> | ||
| <string name="tx_type_dividend_payout">صرف أرباح الأسهم</string> | ||
| <string name="tx_type_overpayment">دفع زائد</string> | ||
| <string name="tx_type_repayment">سداد</string> | ||
| <string name="tx_type_repayment_at_disbursement">سداد عند الصرف</string> | ||
| <string name="tx_type_waive_interest">إعفاء من الفائدة</string> | ||
| <string name="tx_type_waive_charges">إعفاء من الرسوم</string> | ||
| <string name="tx_type_write_off">شطب</string> | ||
| <string name="tx_type_accrual">استحقاق</string> | ||
| <string name="tx_type_approval">موافقة</string> | ||
| <string name="tx_type_undo_approval">تراجع عن الموافقة</string> | ||
| <string name="tx_type_undo_disbursal">تراجع عن الصرف</string> | ||
| <string name="tx_type_reschedule">إعادة جدولة</string> | ||
| <string name="tx_type_recalculate_interest">إعادة احتساب الفائدة</string> | ||
| <string name="tx_type_refund">استرداد</string> | ||
| <string name="tx_type_charge_payment">دفع الرسوم</string> | ||
| <string name="tx_type_loan_charge_added">إضافة رسوم القرض</string> | ||
| <string name="tx_type_interest_waiver">تنازل عن الفائدة</string> | ||
| <string name="tx_type_recover_repayment">استرداد السداد</string> | ||
| <string name="tx_type_credit_balance_refund">رد الرصيد الدائن</string> | ||
| <string name="tx_type_charge_off">إسقاط الدين</string> | ||
| <string name="tx_type_tax_withholding">اقتطاع ضريبي</string> | ||
| <string name="tx_digits">٠١٢٣٤٥٦٧٨٩</string> | ||
| </resources> | ||
Uh oh!
There was an error while loading. Please reload this page.