Skip to content

fix(security): disable verbose Ktor HTTP logging across KMP clients#3141

Open
Divyateja2709 wants to merge 7 commits into
openMF:devfrom
Divyateja2709:new-pr1
Open

fix(security): disable verbose Ktor HTTP logging across KMP clients#3141
Divyateja2709 wants to merge 7 commits into
openMF:devfrom
Divyateja2709:new-pr1

Conversation

@Divyateja2709
Copy link
Copy Markdown

Summary

This PR hardens network logging behavior by disabling verbose Ktor HTTP logs across all platform-specific HttpClient implementations.

Changes

Updated the following files:

  • core/network/src/androidMain/kotlin/org/mifos/mobile/core/network/KtorHttpClient.android.kt
  • core/network/src/desktopMain/kotlin/org/mifos/mobile/core/network/KtorHttpClient.desktop.kt
  • core/network/src/nativeMain/kotlin/org/mifos/mobile/core/network/KtorHttpClient.native.kt
  • core/network/src/jsMain/kotlin/org/mifos/mobile/core/network/KtorHttpClient.js.kt
  • core/network/src/wasmJsMain/kotlin/org/mifos/mobile/core/network/KtorHttpClient.wasmJs.kt

In each file:

  • Changed Logging level from LogLevel.ALL to LogLevel.NONE
  • Added a short comment explaining the security rationale

Why

LogLevel.ALL may expose sensitive request/response details (including auth-related data) through logs.
Disabling verbose logging reduces data exposure risk and aligns with the security remediation goals from the Cipher initiative.

Scope

  • Small and focused hardening change
  • No API contract changes
  • No feature behavior changes

Validation

  • Lint check on edited files: no issues reported.

@Divyateja2709 Divyateja2709 requested a review from a team May 10, 2026 13:22
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 10, 2026

Warning

Rate limit exceeded

@Divyateja2709 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 33 minutes and 16 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f4cc756b-aa0f-4619-bd3e-23e508ff8d2d

📥 Commits

Reviewing files that changed from the base of the PR and between 4ce645a and ef6abe2.

📒 Files selected for processing (69)
  • cmp-navigation/build.gradle.kts
  • cmp-navigation/src/commonMain/kotlin/cmp/navigation/di/KoinModules.kt
  • core-base/security/build.gradle.kts
  • core-base/security/consumer-rules.pro
  • core-base/security/src/androidMain/kotlin/template/core/base/security/BiometricAuthenticator.kt
  • core-base/security/src/androidMain/kotlin/template/core/base/security/BuildInfo.kt
  • core-base/security/src/androidMain/kotlin/template/core/base/security/FieldEncryptor.kt
  • core-base/security/src/androidMain/kotlin/template/core/base/security/SecureKeyProvider.kt
  • core-base/security/src/androidMain/kotlin/template/core/base/security/SecureRandom.kt
  • core-base/security/src/androidMain/kotlin/template/core/base/security/SecureWiper.kt
  • core-base/security/src/androidMain/kotlin/template/core/base/security/TamperDetector.kt
  • core-base/security/src/androidMain/kotlin/template/core/base/security/di/SecurityModule.android.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/BiometricAuthenticator.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/BuildInfo.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/CertificatePinConfig.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/DeepLinkValidator.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/FailedAttemptTracker.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/FieldEncryptor.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/SecureAuthManager.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/SecureKeyProvider.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/SecureNavHandler.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/SecureRandom.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/SecureWiper.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/SecurityConfig.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/SecurityGate.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/SecurityPolicy.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/SecurityState.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/SensitiveString.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/SessionManager.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/TamperDetector.kt
  • core-base/security/src/commonMain/kotlin/template/core/base/security/di/SecurityModule.kt
  • core-base/security/src/commonTest/kotlin/template/core/base/security/DeepLinkValidatorTest.kt
  • core-base/security/src/commonTest/kotlin/template/core/base/security/FailedAttemptTrackerTest.kt
  • core-base/security/src/commonTest/kotlin/template/core/base/security/SecureAuthManagerTest.kt
  • core-base/security/src/commonTest/kotlin/template/core/base/security/SecureNavHandlerTest.kt
  • core-base/security/src/commonTest/kotlin/template/core/base/security/SecurityStateTest.kt
  • core-base/security/src/commonTest/kotlin/template/core/base/security/SensitiveStringTest.kt
  • core-base/security/src/commonTest/kotlin/template/core/base/security/SessionManagerTest.kt
  • core-base/security/src/desktopMain/kotlin/template/core/base/security/BiometricAuthenticator.kt
  • core-base/security/src/desktopMain/kotlin/template/core/base/security/BuildInfo.kt
  • core-base/security/src/desktopMain/kotlin/template/core/base/security/FieldEncryptor.kt
  • core-base/security/src/desktopMain/kotlin/template/core/base/security/SecureKeyProvider.kt
  • core-base/security/src/desktopMain/kotlin/template/core/base/security/SecureRandom.kt
  • core-base/security/src/desktopMain/kotlin/template/core/base/security/SecureWiper.kt
  • core-base/security/src/desktopMain/kotlin/template/core/base/security/TamperDetector.kt
  • core-base/security/src/desktopMain/kotlin/template/core/base/security/di/SecurityModule.desktop.kt
  • core-base/security/src/jsCommonMain/kotlin/template/core/base/security/BiometricAuthenticator.kt
  • core-base/security/src/jsCommonMain/kotlin/template/core/base/security/BuildInfo.kt
  • core-base/security/src/jsCommonMain/kotlin/template/core/base/security/FieldEncryptor.kt
  • core-base/security/src/jsCommonMain/kotlin/template/core/base/security/SecureKeyProvider.kt
  • core-base/security/src/jsCommonMain/kotlin/template/core/base/security/SecureRandom.kt
  • core-base/security/src/jsCommonMain/kotlin/template/core/base/security/SecureWiper.kt
  • core-base/security/src/jsCommonMain/kotlin/template/core/base/security/TamperDetector.kt
  • core-base/security/src/jsCommonMain/kotlin/template/core/base/security/di/SecurityModule.kt
  • core-base/security/src/nativeMain/kotlin/template/core/base/security/BiometricAuthenticator.kt
  • core-base/security/src/nativeMain/kotlin/template/core/base/security/BuildInfo.kt
  • core-base/security/src/nativeMain/kotlin/template/core/base/security/FieldEncryptor.kt
  • core-base/security/src/nativeMain/kotlin/template/core/base/security/SecureKeyProvider.kt
  • core-base/security/src/nativeMain/kotlin/template/core/base/security/SecureRandom.kt
  • core-base/security/src/nativeMain/kotlin/template/core/base/security/SecureWiper.kt
  • core-base/security/src/nativeMain/kotlin/template/core/base/security/TamperDetector.kt
  • core-base/security/src/nativeMain/kotlin/template/core/base/security/di/SecurityModule.native.kt
  • core/network/src/androidMain/kotlin/org/mifos/mobile/core/network/KtorHttpClient.android.kt
  • core/network/src/desktopMain/kotlin/org/mifos/mobile/core/network/KtorHttpClient.desktop.kt
  • core/network/src/jsMain/kotlin/org/mifos/mobile/core/network/KtorHttpClient.js.kt
  • core/network/src/nativeMain/kotlin/org/mifos/mobile/core/network/KtorHttpClient.native.kt
  • core/network/src/wasmJsMain/kotlin/org/mifos/mobile/core/network/KtorHttpClient.wasmJs.kt
  • gradle/libs.versions.toml
  • settings.gradle.kts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant