Skip to content

build: update Koin dependency aliases and remove BOM usage in KMPKoin…#2658

Open
Paradox01240 wants to merge 1 commit into
openMF:devfrom
Paradox01240:tharusha-gsoc
Open

build: update Koin dependency aliases and remove BOM usage in KMPKoin…#2658
Paradox01240 wants to merge 1 commit into
openMF:devfrom
Paradox01240:tharusha-gsoc

Conversation

@Paradox01240

@Paradox01240 Paradox01240 commented Mar 31, 2026

Copy link
Copy Markdown

Description

Fixes an issue in KMPKoinConventionPlugin related to dependency configuration.

Note

I was unable to create a JIRA ticket due to permission restrictions in Apache JIRA.
Requesting maintainers to create/link the issue if required.

Summary by CodeRabbit

  • Chores
    • Updated dependency management configuration to directly specify dependency versions instead of using Bill of Materials lookups, improving build consistency.

@Paradox01240 Paradox01240 requested a review from a team March 31, 2026 01:28
@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 14222436-98dc-40f1-9303-e0ca0303af6c

📥 Commits

Reviewing files that changed from the base of the PR and between afb9ac2 and c6b8bd1.

📒 Files selected for processing (1)
  • build-logic/convention/src/main/kotlin/KMPKoinConventionPlugin.kt

📝 Walkthrough

Walkthrough

The Koin dependency configuration in the KMP convention plugin was refactored from using a Bill of Materials (BOM) approach to direct module declarations, specifying individual Koin artifacts for core, annotations, KSP compiler, and testing.

Changes

Cohort / File(s) Summary
Koin Dependency Configuration
build-logic/convention/src/main/kotlin/KMPKoinConventionPlugin.kt
Removed BOM-based dependency management and replaced with direct additions of koin-core, koin-annotations, koin-ksp-compiler, and koin-test to their respective configurations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 The BOM has hopped away, dear friends,
Direct paths now mark where Koin extends,
Core and annotations in a clearer way,
No platform tricks—just modules at play! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main changes: updating Koin dependency aliases and removing BOM usage in KMPKoinConventionPlugin.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@biplab1

biplab1 commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

@Paradox01240 Welcome to our community! Thank you for your PR.

Please go through this document if you haven't already https://mifosforge.jira.com/wiki/spaces/MP/pages/4537024513/Welcome+to+the+Mifos+Mobile+Apps+Community and feel free to sign up for the daily standup meeting (Mon - Fri, 10 PM IST). Link is in the document.

Anshjn1411 added a commit to Anshjn1411/mifos-x-field-officer-app that referenced this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants