-
Notifications
You must be signed in to change notification settings - Fork 515
add macOS TestFlight and App Store distribution inputs #1943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add macOS TestFlight and App Store distribution inputs #1943
Conversation
WalkthroughTwo new boolean workflow inputs were added to the multi-platform build and publish workflow: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/multi-platform-build-and-publish.yml (1)
37-46: Header documentation for workflow inputs is stale.The
WORKFLOW INPUTSsection in the header (lines 37–46) documents inputs that no longer match the actual inputs defined in the file (e.g., referencespublish_android,build_ios,publish_ioswhich do not exist). While not directly caused by this PR, consider updating this section to reflect the actual inputs, including the newly added macOS distribution options. This is a nice-to-have improvement for maintainability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/multi-platform-build-and-publish.yml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: PR Checks / Static Analysis Check
🔇 Additional comments (3)
.github/workflows/multi-platform-build-and-publish.yml (3)
92-100: Input declarations follow established patterns and are well-formed.The two new macOS distribution inputs (
distribute_macos_testflightanddistribute_macos_appstore) are consistent with their iOS counterparts—same type (boolean), defaults (false), and description format. Formatting and structure are correct.
138-139: Inputs correctly forwarded to the job.The new inputs are properly passed to the downstream job using valid GitHub Actions expression syntax.
92-100: Consider verifying macOS Firebase distribution support.The iOS distribution options include Firebase (line 77), but no
distribute_macos_firebaseinput is added here. Confirm whether this is intentional (e.g., Firebase doesn't support macOS apps) or if a corresponding macOS Firebase input should also be included for consistency.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.