Skip to content

Conversation

@therajanmaurya
Copy link
Member

@therajanmaurya therajanmaurya commented Nov 25, 2025

Issue Fix

Fixes #{Issue Number}
Jira Task: Task_Number

Screenshots

Description

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

Summary by CodeRabbit

  • Chores
    • Updated interbank API endpoint configuration to align with current service specifications.

✏️ Tip: You can customize this high-level summary in your review settings.

@therajanmaurya therajanmaurya merged commit fddebd9 into development Nov 25, 2025
1 check failed
@therajanmaurya therajanmaurya deleted the interbank-instance-vnext2 branch November 25, 2025 21:06
@coderabbitai
Copy link

coderabbitai bot commented Nov 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The interbank API path constant is updated from vnext1 to vnext2 in BaseURL.kt, changing the API endpoint version. This single-file modification affects how interbank URLs are constructed without altering any logic or control flow.

Changes

Cohort / File(s) Change Summary
API Path Version Update
core/network/src/commonMain/kotlin/org/mifospay/core/network/utils/BaseURL.kt
Updated API_PATH_INTERBANK constant from "/v1.0/vnext1/" to "/v1.0/vnext2/"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Fix: update instance to mifos-bank-2 #1944: Both PRs modify public constants in the same core/network/.../BaseURL.kt file, with this PR updating API_PATH_INTERBANK and the related PR updating FINERACT_PLATFORM_TENANT_ID.

Poem

🐰 From vnext one to vnext two we hop,
The interbank path takes a leap,
One constant change, no logic to stop,
Just a version bump so clean and steep! 🚀

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch interbank-instance-vnext2

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e5f56f and 482a14e.

📒 Files selected for processing (1)
  • core/network/src/commonMain/kotlin/org/mifospay/core/network/utils/BaseURL.kt (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants