Skip to content

Conversation

@sahilshivekar
Copy link

Jira Task: 324

Screen recording

Verify old passcode → Create → Confirm → Success dialog → Back to Settings.

change_passcode.mp4

Description

Summary

  • Fix “Change Passcode” not triggering.
  • Implement full flow: verify current passcode → create new passcode → confirm passcode → save passcode → success dialog → return to Settings.

Changes made ->

  • Passcode screen is outside Main_Graph; pass rootNavController to MifosNavHost to support cross-graph navigation.
  • Navigation arg: Added INTENTION query parameter (String) and Intention enum (CHANGE_PASSCODE, LOGIN_WITH_PASSCODE, CREATE_PASSCODE) to drive passcode screen state.
  • INTENTION defaults to LOGIN_WITH_PASSCODE because rootNavGraph uses PASSCODE_GRAPH startDestination (not PASSCODE_SCREEN).

Other related/connected minor changes ->

  • Fix navigating to home screen even after entering wrong passcode
  • Fix navigating to home screen even when "Forgot Passcode? Login manually" button is clicked
  • For both of the fixes only single line changes are made in MifosNavHost.

@coderabbitai
Copy link

coderabbitai bot commented Dec 27, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sahilshivekar sahilshivekar force-pushed the feature/mw-324-change-passcode branch from 2f7982b to 4e94fbe Compare December 29, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant