[GOV-75] #106
[GOV-75] #106
Conversation
| ObjectMapper objectMapper = new ObjectMapper(); | ||
| List<Batch> batches = Arrays.asList(objectMapper.readValue(jsonString, Batch[].class)); | ||
|
|
||
| for (Batch bt : batches) { | ||
| Optional<Batch> existingBatchOpt = batchRepository.findBySubBatchId(bt.getSubBatchId()); | ||
|
|
||
| Optional<TransferTransformerConfig.Flow> config = transferTransformerConfig.findFlow(bpmn); | ||
| if(!config.get().getName().contains("bulk_processor")) { |
There was a problem hiding this comment.
What if there are other workflows that are having this word bulk processor.
There was a problem hiding this comment.
It's done on purpose, I want it only to work with bulk_connector flows.
There was a problem hiding this comment.
@fynmanoj The bpmn name having bulk_processor is the parent( or batches product flow), so if in future if we have any more bpmn names with bulk processor it will be for parent flow only. Here in this scenario we need to exclude these cases and only enter data into transfers table when the type is batches and the flow is a child(debulked/implementation flow based on payment mode).
There was a problem hiding this comment.
If this scenario is specific to workflow, can't we use the the full workflow name ie bulk_processor_dfspid. We need to use available dfsp IDs instead of the placeholder dfspid.
The idea is to make this line specific and to avoid technical debt for future enhancements
Description
(Ignore if these details are present on the associated JIRA ticket)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Design related bullet points or design document link related to this PR added in the description above.
Updated corresponding Postman Collection or Api documentation for the changes in this PR.
Create/update unit or integration tests for verifying the changes made.
Add required Swagger annotation and update API documentation with details of any API changes if applicable
Followed the naming conventions as given in https://docs.google.com/document/d/1Q4vaMSzrTxxh9TS0RILuNkSkYCxotuYk1Xe0CMIkkCU/edit?usp=sharing