Extract metadata from CITATION.cff#90
Extract metadata from CITATION.cff#90Raphael-Gazzotti wants to merge 9 commits intoopenMetadataInitiative:mainfrom
Conversation
…, license, title -fullName, shortName-, versionIdentifier
|
The pull request seems reasonable. Can you add some tests for it, please? |
bids2openminds/main.py
Outdated
| if 'orcid' in person: | ||
| person_orcid = omcore.ORCID(identifier=person['orcid']) | ||
| if 'affiliation' in person: | ||
| person_affiliation = omcore.Affiliation(person['affiliation']) |
There was a problem hiding this comment.
this seems incomplete. The affiliation should contain one or more Organization or Consortium instances, in the "member_of" property.
There was a problem hiding this comment.
Indeed, I’ve updated it. However, there’s an implementation choice to make: should we treat everything in the affiliation field as a single, unique organization, or should we implement rules to distinguish between them?
For now, I’ve gone with the first option, considering everything in affiliation as a single organization, but it’s probably safer to not consider the affiliation field at the moment.
There was a problem hiding this comment.
the format seems to expect a single affiliation. I think it's reasonable to assume a single organisation.
It will be very difficult to reliably detect multiple organisations - maybe implement something simple like splitting the string on ";" - this character would not normally be used within the name/address of a single organisation.
Co-authored-by: Andrew Davison <andrew.davison@cnrs.fr>
|
@Peyman-N I added some tests to cover the new extraction. |
lzehl
left a comment
lzehl
left a comment
There was a problem hiding this comment.
@apdavison or @Peyman-N please one of you double check. It looks good from my side and can be merged by the next one confirming the PR
Raphael-Gazzotti
force-pushed
the
citation-file-handling
branch
2 times, most recently
from
8692e9e to
e8efa81
Compare
4 participants
Extracts metadata from CITATION.cff including:
Also lays groundwork for extracting additional information such as preferred-citation.
Closes #89