Skip to content

Add check for newline at the end of JSON files. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Raphael-Gazzotti wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add check for newline at the end of JSON files. #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions openMINDS_validation/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,15 @@ def __init__(self, path_versions):
path_versions)
self.versions = load_json(path_versions)

def load_json(path):
with open(path) as f:
def check_newline_end_of_file(file_path):
with open(file_path, 'rb') as f:
f.seek(-2, 2)
if f.read(2) != b'}\n':
logging.error(f'No newline at end of file "{file_path}".')

def load_json(file_path):
check_newline_end_of_file(file_path)
with open(file_path) as f:
json_file = json.load(f)
return json_file

Expand Down