Add validation for @id naming based on abbreviation/name convention.#28
Open
Raphael-Gazzotti wants to merge 2 commits intoopenMetadataInitiative:mainfrom
Open
Add validation for @id naming based on abbreviation/name convention.#28Raphael-Gazzotti wants to merge 2 commits intoopenMetadataInitiative:mainfrom
Raphael-Gazzotti wants to merge 2 commits intoopenMetadataInitiative:mainfrom
Conversation
apdavison
reviewed
Jan 13, 2026
| for item in value: | ||
| self._nested_instance(item, function, instance_type) | ||
|
|
||
| def _check_atid_naming(self): |
Member
There was a problem hiding this comment.
It would be nice to add some unit tests for this repository. The central part of this method should perhaps be extracted as a function generate_expected_atid_name(name) to make testing easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.