Docs: makeConstant & Parallel HDF5 #1041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In parallel HDF5, attribute writes are all collective.
ax3l
force-pushed
the
doc-makeConstantHDF5Collective
branch
from
2e0807b to
025e241
Compare
LDAmorim
approved these changes
Jul 9, 2021
|
|
||
| E_x.resetDataset( { Datatype::DOUBLE, { mpi_size * 2, 10, 6, 8 } } ); | ||
|
|
||
| // HDF5 Attribute writes are unfortunately collective |
Member
There was a problem hiding this comment.
Thank you!
This PR makes it very clear and I think it will prevent other users (like myself in the future) from doing the mistake I was doing (mentioned in #1021 - as part of the replies).
Member
Author
There was a problem hiding this comment.
Glad this helps. Yes, the HDF5 attribute limitations are unfortunate, definitely forgot to document the implications on constant record components more clearly :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In parallel HDF5, attribute writes are all collective.
Also document another PHDF5 constrain with chunking from #916, which is now default-on.
Document for a question in #1021 (comment)
Close #1021