-
Notifications
You must be signed in to change notification settings - Fork 52
JSON update #1043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
JSON update #1043
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
6da2f4d
New error type: BackendConfigSchema
franzpoeschel 2ce67dc
Update to JSON.hpp auxiliary header (now JSON_internal.hpp)
franzpoeschel b0b31b9
Use TracingJSON from the start already
franzpoeschel af40454
Use JSON to set dataset transform in ADIOS1
franzpoeschel 65624fe
Remove Dataset::compression, ::transform and ::chunksize
franzpoeschel 46b2b56
Use JSON config in MPI benchmarks
franzpoeschel e9ec75f
Improvements to ADIOS2 and HDF5
franzpoeschel 399686b
Series global keys: backend and iteration_encoding
franzpoeschel 241f9db
Documentation
franzpoeschel 9d2ffcc
Use fancy C++ strings
franzpoeschel 49a980d
Correct precedence in ADIOS2: env var vs. JSON param
franzpoeschel 67ca661
Lower case transformation: Ignore some paths in JSON
franzpoeschel f2fac75
Add json::merge, including test
franzpoeschel 3273b0c
Use {"backend": <backend_name>} in tests
franzpoeschel 276c50e
Warn if using contradicting filename extension to backend key
franzpoeschel 99a307c
Move JSON test to separate binary
franzpoeschel 2508a78
Apply suggestions from code review
franzpoeschel b7312eb
Remove duplicate friend declarations
franzpoeschel 6065d56
HDF5 fix (to be rebased)
franzpoeschel 965bc07
Fix verbatim chevrons in Doxygen
ax3l bd99789
Some commenting on backend_via_json test
franzpoeschel f9c2f8c
Add breaking changes to NEWS.rst
franzpoeschel a69af6c
Doxygen: Warn Unused JSON Params
ax3l File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"adios2": { | ||
"dataset": { | ||
"transform": "blosc:compressor=zlib,shuffle=bit,lvl=1;nometa" | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need a test or option for this, since blosc is not always there.
On the other hand: ADIOS2 will just warn if not, and keeps going without it.
My go-to compressor is parallel
zstd
in blosc though :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be sure, you mean zstd instead of blosc? Or is there a way to pick zstd inside blosc? This current configuration will just select whatever defaults that ADIOS2 defines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latter! blosc is a meta-compressor and implements threaded compression routines for zlib, zstd, lz4, blosclz, etc.:
https://www.blosc.org/pages/blosc-in-depth
here is an example how I use blosc with threaded zstd compressor for openPMD output in WarpX:
And this is how I did it in ADIOS1 in PIConGPU:
See also Fig. 4 in https://arxiv.org/abs/1706.00522 - the threaded compressors are all via blosc.