[WIP] More Emscripten/pyiode Python #1201
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
commented
Feb 15, 2022
| @@ -1,6 +1,6 @@ | |||
| [build-system] | |||
| requires = [ | |||
| "setuptools>=42", | |||
| "setuptools>=57.4", | |||
There was a problem hiding this comment.
Introduces the env var SETUPTOOLS_EXT_SUFFIX (ref)
ax3l
commented
Feb 15, 2022
| @@ -35,6 +35,18 @@ def run(self): | |||
| for ext in self.extensions: | |||
| self.build_extension(ext) | |||
|
|
|||
| def get_ext_filename(self, ext_name): | |||
There was a problem hiding this comment.
Overwritten temporarily since it looks like the build_wheel step does not have the same env vars in pyoide than the earlier steps during build.
Wheel packaging still does not pick up the openpmd_api_cxx shared lib though...
ax3l
commented
Feb 15, 2022
| @@ -186,7 +195,7 @@ def build_extension(self, ext): | |||
| 'Source': 'https://github.com/openPMD/openPMD-api', | |||
| 'Tracker': 'https://github.com/openPMD/openPMD-api/issues', | |||
| }, | |||
| ext_modules=[CMakeExtension('openpmd_api_cxx')], | |||
| ext_modules=[CMakeExtension('openpmd_api.openpmd_api_cxx')], | |||
There was a problem hiding this comment.
Playing with declaring the full sub-module here does not help either with the install pick-up-to-wheel issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1199
More potential updates related to pyodide/pyodide#2169