-
Notifications
You must be signed in to change notification settings - Fork 51
Add openPMD version 2.0 to supported API versions #1551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sounds good 👍 We could also separate into default/min/max standard for read and write. |
c7e86d4
to
2246928
Compare
Marking this as WIP since I'm using this PR as a common ground for new openPMD 2.0 features and might want to extract more features into it in future. |
c08e6be
to
ebf03ea
Compare
ebf03ea
to
e840175
Compare
e840175
to
1c427ff
Compare
a58ad7c
to
b23d333
Compare
b23d333
to
7ed7af3
Compare
7ed7af3
to
99c9d01
Compare
99c9d01
to
deee96e
Compare
74b90f6
to
8f7ba0a
Compare
3a7f0ae
to
e72602a
Compare
e72602a
to
12595af
Compare
12595af
to
fe5c1b7
Compare
fe5c1b7
to
202e700
Compare
franzpoeschel
commented
Oct 28, 2024
Merged
0a8936f
to
4890c78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not yet add any openPMD 2.0 functionality, but serves as a basis for PRs that add new functionality.
This does not yet set 2.0 as the default written version, hence
getStandard()
needs to be split intogetStandard()
andgetStandardDefault()
.getStandardMax()
additionally and deprecategetStandard()
?