Skip to content

Fix Leftover ADIOS1 Mentions #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Fix Leftover ADIOS1 Mentions #1683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7be9ae
Fix Leftover ADIOS1 Mentions
ax3l Oct 10, 2024
c79e332
Remove ADIOS1 from examples
franzpoeschel Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/Doxyfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
PROJECT_NAME = "openPMD-api"
XML_OUTPUT = xml
INPUT = ../src ../include ../README.md
#EXCLUDE_PATTERNS = *CommonADIOS1IOHandler.cpp

# TAGFILES += "cppreference-doxygen-web.tag.xml=http://en.cppreference.com/w/"
BUILTIN_STL_SUPPORT = YES
Expand Down
2 changes: 1 addition & 1 deletion docs/source/maintenance/release_channels.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Brew
We maintain a `homebrew tap <https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap>`_ for `openPMD <https://github.com/openPMD/homebrew-openPMD>`_.
Provides the C++ and Python API for users.
Supports OSX and Linux.
Its source-only Formula for the latest release includes (Open)MPI support and lacks the ADIOS1 backend.
Its source-only Formula for the latest release includes (Open)MPI support.

Example workflow for a new release:

Expand Down
3 changes: 0 additions & 3 deletions examples/13_write_dynamic_configuration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ iteration_encoding = "group_based"
# The following is only relevant in read mode
defer_iteration_parsing = true

[adios1.dataset]
transform = "blosc:compressor=zlib,shuffle=bit,lvl=5;nometa"

[adios2.engine]
type = "bp4"

Expand Down
3 changes: 0 additions & 3 deletions examples/13_write_dynamic_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@
# The following is only relevant in read mode
defer_iteration_parsing = true

[adios1.dataset]
transform = "blosc:compressor=zlib,shuffle=bit,lvl=5;nometa"

[adios2.engine]
type = "bp4"

Expand Down
5 changes: 0 additions & 5 deletions examples/7_extended_write_serial.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,6 @@ int main()
auto d = io::Dataset(dtype, io::Extent{2, 5});
std::string datasetConfig = R"END(
{
"adios1": {
"dataset": {
"transform": "blosc:compressor=zlib,shuffle=bit,lvl=1;nometa"
}
},
"adios2": {
"dataset": {
"operators": [
Expand Down
5 changes: 0 additions & 5 deletions examples/7_extended_write_serial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,6 @@
# written to disk
d = Dataset(partial_mesh.dtype, extent=[2, 5])
dataset_config = {
"adios1": {
"dataset": {
"transform": "blosc:compressor=zlib,shuffle=bit,lvl=1;nometa"
}
},
"adios2": {
"dataset": {
"operators": [{
Expand Down
2 changes: 1 addition & 1 deletion src/IO/ADIOS/ADIOS2IOHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,7 @@ void ADIOS2IOHandlerImpl::createDataset(
if (parameters.joinedDimension.has_value())
{
error::throwOperationUnsupportedInBackend(
"ADIOS1", "Joined Arrays require ADIOS2 >= v2.9");
"ADIOS2", "Joined Arrays require ADIOS2 >= v2.9");
}
#endif
if (!writable->written)
Expand Down
2 changes: 1 addition & 1 deletion src/IO/HDF5/HDF5IOHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ void HDF5IOHandlerImpl::createDataset(
if (parameters.joinedDimension.has_value())
{
error::throwOperationUnsupportedInBackend(
"ADIOS1", "Joined Arrays currently only supported in ADIOS2");
"HDF5", "Joined Arrays currently only supported in ADIOS2");
}

if (!writable->written)
Expand Down
2 changes: 1 addition & 1 deletion src/IO/JSON/JSONIOHandlerImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ void JSONIOHandlerImpl::createDataset(
if (parameter.joinedDimension.has_value())
{
error::throwOperationUnsupportedInBackend(
"ADIOS1", "Joined Arrays currently only supported in ADIOS2");
"JSON", "Joined Arrays currently only supported in ADIOS2");
}

if (!writable->written)
Expand Down
Loading