Skip to content

CI: Move Ubuntu 20.04 workflows to 22.04 #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Mar 21, 2025
Merged

CI: Move Ubuntu 20.04 workflows to 22.04 #1731

merged 40 commits into from
Mar 21, 2025

Conversation

franzpoeschel
Copy link
Contributor

Ubuntu 20.04 runners shutting down April 1st

@franzpoeschel franzpoeschel force-pushed the ci-ubuntu-22.04 branch 2 times, most recently from 4fd5250 to fc589e4 Compare March 5, 2025 17:09
franzpoeschel
franzpoeschel commented Mar 5, 2025
View reviewed changes
@ax3l
Copy link
Member

ax3l commented Mar 21, 2025

Oh, there is an MPICH bug marked as conflict for the exact MPICH and HDF5 combination we have here.
https://github.com/spack/spack/blob/c79b6207e88b765f9f01401f8145c17746457d09/var/spack/repos/builtin/packages/hdf5/package.py#L156

Let's go to Ubuntu 24.04 then for this runner?

@ax3l ax3l force-pushed the ci-ubuntu-22.04 branch from b37e136 to 90705c6 Compare March 21, 2025 00:12
@ax3l ax3l force-pushed the ci-ubuntu-22.04 branch from 90705c6 to f72f59b Compare March 21, 2025 00:17
@ax3l
Copy link
Member

ax3l commented Mar 21, 2025

I will remove ICC as well with this PR, since it is EOL for 1.5 years or so :)
ICX is the new compiler.

@ax3l ax3l force-pushed the ci-ubuntu-22.04 branch 3 times, most recently from 86cc5e0 to 87f1397 Compare March 21, 2025 06:43
@ax3l ax3l force-pushed the ci-ubuntu-22.04 branch from 87f1397 to 92ff147 Compare March 21, 2025 07:21
ax3l added 2 commits March 21, 2025 00:45
@ax3l
Clang -> GCC
b9c4243 
MPICH alone seems hard enough
@ax3l
GH: 4 vcores on Linux Now
b9d5266
@ax3l ax3l force-pushed the ci-ubuntu-22.04 branch from 3c3cf8f to b9d5266 Compare March 21, 2025 07:49
@franzpoeschel
Copy link
Contributor Author

Wow, the last change definitely worked for my local docker attempt...

I feel your pain

@ax3l
Copy link
Member

ax3l commented Mar 21, 2025

I simplified the test now to only test MPICH with GCC.

Currently it seems to work but the ParallelIO test fails with:

[Fri Mar 21 08:10:04 2025] [ADIOS2 EXCEPTION] <Toolkit>
  <format::BP5Deserializer> <InstallAttributeData> : Internal error or file
  corruption, no know format for Attribute Block

which I am not sure if it is a new MPICH issue or just a compiler build stack issue that we still need to solve in CI (more likely?)

@ax3l
Copy link
Member

ax3l commented Mar 21, 2025

In doubt, if we cannot fix this today, we can exlcude this one runner and add a separate PR that adds again a regular system GCC + system MPICH test to have it (MPICH) covered.

@franzpoeschel
Copy link
Contributor Author

Thank you for fixing the MPICH setup!
I don't think I ever saw this error. I can try investigating that next week, so let's maybe exlude the runner for the moment.

@ax3l
Copy link
Member

ax3l commented Mar 21, 2025

Sounds good! Can you open a PR after this is merged that simply undo's the last commit I added here? :)

@ax3l ax3l enabled auto-merge (squash) March 21, 2025 22:24
@ax3l
Copy link
Member

ax3l commented Mar 21, 2025 •
edited
Loading

Yeah MPICH coverage is pretty important because we use it on all Cray/HPE systems (Frontier, Perlmutter, etc.) So let us definitely try to add one or two versions we can cover for it (and be aware of the HDF5 with MPICH 4.0 issues that Spack documents, no need to support that combination then).

@ax3l ax3l merged commit a258128 into openPMD:dev Mar 21, 2025
30 checks passed
@franzpoeschel franzpoeschel mentioned this pull request Mar 24, 2025
Merged
franzpoeschel added a commit that referenced this pull request Jun 3, 2025
@franzpoeschel
CI: Move Ubuntu 20.04 workflows to 22.04 (#1731)
b800efd
@franzpoeschel franzpoeschel mentioned this pull request Jun 3, 2025
Merged
franzpoeschel added a commit that referenced this pull request Jun 3, 2025
@franzpoeschel @ax3l
Backport recent CI fixes (#1758): #1718 #1731 #1739 #1742
e8debe1 
* RTD: Fix GA Integration (#1718)

GA was dropped from RTD in early Oct, 2024. This adds it again.

* CI: Move Ubuntu 20.04 workflows to 22.04 (#1731)

* Reactivate MPICH runner (gcc13_py312_mpich_h5_ad2) (#1739)

* Revert "CI: Disable MPICH for now"

This reverts commit de9e7ad.

* We shall try installin MPICH from Spack for now

Ubuntu package broken https://bugs.launchpad.net/ubuntu/+source/mpich/+bug/2072338

* Take out version checks

* Revert "Take out version checks"

This reverts commit b22e4b3.

* Revert "We shall try installin MPICH from Spack for now"

This reverts commit 33b847f.

* Alternative approach: self-compiled MPICH

* Move MPICH installation to separate file

* Fix broken CI: Support for old CMake versions (#1742)

* Check for broken CI

* Deactivate dependencies that are not yet compatible with CMake 4.0

* Fixes

* Upgrade Spack

* Fix warning

* Fixes after upgrading spack

---------

Co-authored-by: Axel Huebl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels

continuous integration

Projects

None yet

Milestone

0.16.2

Development

Successfully merging this pull request may close these issues.

2 participants

@franzpoeschel @ax3l