Skip to content

Conversation

franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented Mar 20, 2025

Closes #1723

  • Can now pass Path for filepath parameter of constructor
  • Can now pass JSON dicts for options parameter of constructor (will internally call json.dumps()

TODO

  • The constructor can at the moment not automatically distinguish if the parameter is an MPI communicator or a JSON object since both overloads accept py::object, making explicit options={} necessary. Maybe find a way to fix this somehow..?
  • Document new internal CMake option
  • Testing, examples
  • Use -DopenPMD_USE_FILESYSTEM_HEADER in some CI run
  • Enable <filesystem> header for prebuilt Wheels?

@franzpoeschel franzpoeschel force-pushed the python-series-constructor-conversions branch from d19de24 to dd1939c Compare April 2, 2025 16:43
@franzpoeschel franzpoeschel enabled auto-merge (squash) April 3, 2025 11:42
@franzpoeschel franzpoeschel added this to the 0.17.0 milestone Apr 3, 2025
@franzpoeschel franzpoeschel merged commit 6d02d44 into openPMD:dev Apr 3, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for python Path as io.Series argument

1 participant