Fix error when reading in linear mode from file-based Series #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzpoeschel
commented
Apr 17, 2025
| @@ -648,6 +648,8 @@ std::optional<StatefulIterator *> StatefulIterator::loopBody(Seek const &seek) | |||
| else if ( | |||
| series.IOHandler()->m_frontendAccess == Access::READ_LINEAR) | |||
| { | |||
| std::cout << "Closing Iteration " << *maybe_current_iteration | |||
There was a problem hiding this comment.
TODO: remove this bit again
just as a reminder for myself where this error is caused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens, since the new
series.snapshots()logic will remove Iterations from the object model once they are closed by the user, leading to a situation where at the end of the Series the Iterations container might be empty.