Skip to content

Fix missing check for constant components #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franzpoeschel merged 2 commits into from
Aug 8, 2025
Merged

Fix missing check for constant components #1776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c68593
Add missing check
franzpoeschel Aug 7, 2025
a8ffae3
Fix test
franzpoeschel Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/RecordComponent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ void RecordComponent::flush(
{
// The check for !written() is technically not needed, just
// defensive programming against internal bugs that go on us.
if (!written() && rc.m_chunks.empty())
if (!written() && rc.m_chunks.empty() && !rc.m_isConstant)
{
// No data written yet, just accessed the object so far without
// doing anything
Expand All @@ -283,7 +283,8 @@ void RecordComponent::flush(
{
throw error::WrongAPIUsage(
"[RecordComponent] Must specify dataset type and extent "
"before flushing (see RecordComponent::resetDataset()).");
"before flushing or setting a constant value (see "
"RecordComponent::resetDataset()).");
}
}
if (!containsAttribute("unitSI"))
Expand Down
2 changes: 2 additions & 0 deletions test/python/unittest/API/APITest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ def refcountingCreateData(self):
for dim in ["x", "y"]:
# Do not bother with a positionOffset
position_offset = e["positionOffset"][dim]
position_offset.reset_dataset(
io.Dataset(np.dtype("int"), [100]))
position_offset.make_constant(0)

position = e["position"][dim]
Expand Down
Loading