Fixes for deferred initialization #1777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzpoeschel
force-pushed
the
fix-deferred-container-initialization
branch
from
35ee920 to
e82be0d
Compare
franzpoeschel
added a commit
to franzpoeschel/openPMD-api
that referenced
this pull request
Sep 16, 2025
Accidentally merged this along with openPMD#1777
franzpoeschel
added a commit
that referenced
this pull request
Sep 16, 2025
Accidentally merged this along with #1777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Series::snapshots(), the stateful container initialization is deferred, since IO accesses should occur only upon user request and not earlier. However, it currently had no constructor without deferring, leading to troubles when accessing the container as const, because initialization can only done as non-const.This adds a non-deferred constructor, using deferred initialization only in such cases where IO accesses are actual deferred.
TODO: