Clang Tidy and Sanitizer: Use clang-19 on Ubuntu 24.04 #1783
Conversation
does not work
franzpoeschel
force-pushed
the
clang-tidy-sanitizer-ubuntu-24.04
branch
from
f833106 to
58fbcad
Compare
franzpoeschel
force-pushed
the
clang-tidy-sanitizer-ubuntu-24.04
branch
from
58fbcad to
1d41d46
Compare
|
|
||
| mirrors: | ||
| E4S: https://cache.e4s.io | ||
| spack-public: https://mirror.spack.io |
There was a problem hiding this comment.
Please check the change of mirror URL, cache.e4s.io is outdated
| share/openPMD/download_samples.sh build | ||
| export LDFLAGS="${LDFLAGS} -fsanitize=address,undefined -shared-libsan" | ||
| export CXXFLAGS="${CXXFLAGS} -fsanitize=address,undefined -shared-libsan" | ||
| export CXXFLAGS="${CXXFLAGS} -fsanitize=address,undefined -shared-libsan -DOMPI_SKIP_MPICXX" |
There was a problem hiding this comment.
Please check -DOMPI_SKIP_MPICXX. For some reason, this run pulls in the C++ bindings of MPI and then fails. This can be avoided with this preprocessor define, but there might be a better solution. I see that we have some finicky config in CMakeLists.txt on whether we link with MPI::MPI_C or MPI::MPI_CXX. Changing one to the other made no difference in my tests.
There was a problem hiding this comment.
I found in the past that surprisingly, the C API of MPI sometimes depends on the (outdated) C++ bindings (e.g., BullMPI, which is an OpenMPI variant)
There was a problem hiding this comment.
We need C CXX but not MPICXX
https://cmake.org/cmake/help/latest/module/FindMPI.html
There was a problem hiding this comment.
There is a CMake option MPI_CXX_SKIP_MPICXX
Add some definitions that will disable the MPI-2 C++ bindings. Currently supported are MPICH, Open MPI, Platform MPI and derivatives thereof, for example MVAPICH or Intel MPI.
Let's add that! :)
There was a problem hiding this comment.
We will do that in a follow-up PR, so we can patch it out if it causes issues after all.
2 participants
Uh oh!
There was an error while loading. Please reload this page.