Symbol visibility: Hidden by default #1793
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzpoeschel
added
bug
help wanted
discussion
install
api: breaking
ax3l
reviewed
Oct 14, 2025
Comment on lines
+546
to
+549
| set_target_properties(openPMD PROPERTIES | ||
| CXX_VISIBILITY_PRESET hidden | ||
| VISIBILITY_INLINES_HIDDEN ON | ||
| ) |
There was a problem hiding this comment.
We did this for the old ADIOS1 libraries if you like to take a look:
https://github.com/openPMD/openPMD-api/blob/0.14.5/CMakeLists.txt#L555-L571
ax3l
reviewed
Oct 14, 2025
|
|
||
| # symbol hiding | ||
| if(openPMD_HAVE_SYMBOLHIDING) | ||
| set_target_properties(openPMD PROPERTIES |
There was a problem hiding this comment.
This will not work for C++ users, unless you explicitly export all our public C++ APIs.
Already, we should not be exporting C++ stdlib symbols, I think. I think that mixing different C++ stdlibs generally does not work in the same process, just how the dynamic loader works and populates symbols. But this is not needed in most cases, e.g., on HPC one does instead compile with a consistent set of compilers/modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revisits #165 as an attempt to fix software stack issues such as #1792 where binary-incompatible versions of e.g. the C++ stdlib are used by openPMD-api and other packages.
TODO: