Skip to content

[WIP] Remember Release Channel #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

[WIP] Remember Release Channel #375

wants to merge 2 commits into from

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Sep 25, 2018 •
edited
Loading

Close #374

  • CMake option
  • Macro stringizing or hpp.in configure?
  • C++ API
  • Python API

Update release channels:

ax3l
ax3l commented Sep 25, 2018
View reviewed changes
openPMDConfig.cmake.in Outdated
@@ -4,6 +4,8 @@ include(CMakeFindDependencyMacro)

list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/Modules")

set(openPMD_RELEASE_CHANNEL @openPMD_RELEASE_CHANNEL@)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this need quotes?

@ax3l ax3l changed the title [WIP] Release Channel [WIP] Remember Release Channel Sep 25, 2018
@ax3l ax3l force-pushed the topic-releaseChannel branch from aea953b to f7e6230 Compare September 25, 2018 21:47
@ax3l ax3l changed the title [WIP] Remember Release Channel Remember Release Channel Sep 25, 2018
@ax3l ax3l force-pushed the topic-releaseChannel branch 2 times, most recently from 8467aac to ec2a1b3 Compare September 25, 2018 22:03
@ax3l ax3l changed the title Remember Release Channel [WIP] Remember Release Channel Sep 25, 2018
ax3l added 2 commits August 28, 2019 11:07
@ax3l
Cmake: Release Channel
e5d87d9 
Add support for an `openPMD_RELEASE_CHANNEL` variable.
This var can be set in conda/spack/pypi/... release channels to
something different than "source" and we can ask the user later on
for it via a simple runtime API call.
@ax3l
Python: openPMD-api release channel
1cc01b0 
Expose as module attribute.
@ax3l ax3l force-pushed the topic-releaseChannel branch from ec2a1b3 to 1cc01b0 Compare August 28, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
continuous deployment automated shipping documentation install
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ax3l