Skip to content

Use schema-based versioning in ADIOS2 backend #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 25, 2021
Merged

Use schema-based versioning in ADIOS2 backend #941

merged 6 commits into from
Mar 25, 2021

Conversation

franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented Mar 8, 2021 •
edited
Loading

This steals and isolates some commits of #855:

  • Use YYYYMMDD format for the schema used in ADIOS2
  • Automatically recognize the right schema when reading

TODO

  • Remove some unnecessary changes that are only relevant to Variable-Based iteration layout #855
  • Documentation
  • Remove the new_attribute_layout from some leftover places
  • Merge ADIOS2: v2.7.0+ #927 first
  • Merge Decay ReadWrite mode into adios2::Mode::Read if the file exists #943 first
  • This PR also fixes two bugs that I encountered while working on it. Should I separate those into another PR?
    1. Read-Write mode should inspect whether the file already exists and chose read-only or write-only mode accordingly. Properly supporting ADIOS Append mode is a Todo for the future though.
    2. Parallel IO tests check the wrong file name for existence.
  • Rename __is_boolean__/(.*) to __openPMD_internal/is_boolean/\1 in new schema

@franzpoeschel franzpoeschel force-pushed the topic-adios2-schema branch 2 times, most recently from 48f8846 to 5d33500 Compare March 8, 2021 11:38
@franzpoeschel franzpoeschel mentioned this pull request Mar 8, 2021
Merged
13 tasks
@ax3l ax3l self-requested a review March 9, 2021 18:31
@ax3l ax3l self-assigned this Mar 9, 2021
@ax3l ax3l requested a review from guj March 9, 2021 18:34
@ax3l
Copy link
Member

ax3l commented Mar 10, 2021

@franzpoeschel This PR also fixes two bugs that I encountered while working on it. Should I separate those into another PR?

Yes, that would be great in case I need to patch & cherry-pick them around! Thanks!

@franzpoeschel franzpoeschel mentioned this pull request Mar 22, 2021
Merged
7 tasks
@franzpoeschel
Copy link
Contributor Author

Ready for review (if CI goes green) :) @ax3l

ax3l
ax3l approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ax3l ax3l merged commit def88c3 into openPMD:dev Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ax3l ax3l ax3l approved these changes

@guj guj Awaiting requested review from guj

Assignees

@ax3l ax3l

Labels

backend: ADIOS2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@franzpoeschel @ax3l