HDF5: Fix Segfault with libSplash Files #962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a segfault (on some systems) with legacy libSplash HDF5 files. From the docs: ``` Name: H5Tget_member_name ... The HDF5 Library allocates a buffer to receive the name of the field. The caller must subsequently free the buffer with H5free_memory. ``` Refs.: - https://support.hdfgroup.org/HDF5/doc/RM/RM_H5T.html#Datatype-GetMemberName - https://support.hdfgroup.org/HDF5/doc/RM/RM_H5.html#Library-FreeMemory
ax3l
commented
Apr 8, 2021
Passing potential `nullptr`s is undefined behavior.
ax3l
commented
Apr 8, 2021
ax3l
added a commit
to ax3l/openPMD-api
that referenced
this pull request
Apr 9, 2021
* HDF5: Fix Segfault with libSplash Files Fix a segfault (on some systems) with legacy libSplash HDF5 files. From the docs: ``` Name: H5Tget_member_name ... The HDF5 Library allocates a buffer to receive the name of the field. The caller must subsequently free the buffer with H5free_memory. ``` Refs.: - https://support.hdfgroup.org/HDF5/doc/RM/RM_H5T.html#Datatype-GetMemberName - https://support.hdfgroup.org/HDF5/doc/RM/RM_H5.html#Library-FreeMemory * avoid undefined behavior in str(n)cmp Passing potential `nullptr`s is undefined behavior. * Clang-Tidy: Intentional Branch Clone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #939: a segfault (triggered reproducibly with pip builds) with legacy libSplash HDF5 files.
Introduced in #641 (
0.10.3-alphaand newer).From the docs:
I did not need this in my test to fix the segfault, but revisiting the logic I also noticed that passing
nullptrs tostr(n)cmpis undefined behavior and fixed that as well.Refs.:
IN: Buffer to be freed. Can be NULL.)