Remove proton/neutron Number #192
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the proton/neutron number from the
ED-PIC
extension, since it is now possible to specify it withSpeciesType
.Implements issue: Close #191
Affected Components
EXT_ED-PIC
Logic Changes
Expressing ions in
ED-PIC
can now be done by using theSpeciesType
extension.Writer Changes
Data writers that were writing the proton/neutron number should now use the
SpeciesType
extension.This might require a lookup of an element name in the periodic table for the naming. Previously, one could just define two numbers without knowing how an ion/isotope is abbreviated in the periodic table.
Reader Changes
I am not aware of any reader that currently checks this attribute, but in theory data readers should now look at the
SpeciesType
information.openPMD-validator
: remove check inED-PIC
ED-PIC: Remove proton/neutron Number openPMD-validator#39Data Converter
Data converters should switch to using the
SpeciesType
.