fix: inline client config into app shell#477
Conversation
|
🚀 Preview deployed! 🔗 https://rin-server-pr-477.88799f0e5e3819fb745c9f69b086565a.workers.dev |
|
🧹 Preview deployment has been cleaned up. The temporary preview environment for this PR has been deleted. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf7bf6fff1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const indexResponse = await env.ASSETS.fetch(indexRequest); | ||
| if (indexResponse.status === 200 || (indexResponse.status >= 300 && indexResponse.status < 400)) { | ||
| return indexResponse; | ||
| return injectClientConfigIntoHtml(indexResponse, env); |
There was a problem hiding this comment.
Returning injectClientConfigIntoHtml(...) directly from the try block means any async failure while building client config (DB/S3/cache read) bypasses this catch, because rejected promises are not caught unless awaited. In that failure mode the SPA shell request rejects instead of falling back to the static indexResponse, so transient config-store issues can turn normal page loads into worker errors.
Useful? React with 👍 / 👎.
| const headers = new Headers(response.headers); | ||
| headers.set("content-length", String(new TextEncoder().encode(nextHtml).byteLength)); |
There was a problem hiding this comment.
This clones all original asset headers (including validators like ETag/Last-Modified) even though the response body is rewritten with runtime config. Because config can change independently of the static asset, clients may revalidate against an unchanged asset tag and keep using cached HTML with old inline config (or receive 304), so admin config updates are not reliably reflected on reload.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing