Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative downloads #224

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

lkocman
Copy link
Contributor

@lkocman lkocman commented Oct 10, 2024

  • Use single page download layout for Leap and Tumbleweed.
  • Keep Micro as it is
  • Display heading for install images in cases without alternative_downloads on a separate page.
  • Display option to get further images from download server for distros with single page download layout

image
image

And old-style Micro
image
image

Leap Micro since it has only one page gets to display pointer to download server.

* Switch them to single page download mode
* Keep Micro on existing layouts with alternative downloads window
@lkocman
Copy link
Contributor Author

lkocman commented Oct 10, 2024

@DimStar77 agreed to re-use single page download layout also for Tumbleweed

@lkocman
Copy link
Contributor Author

lkocman commented Oct 11, 2024

@hellcp what's your recommendation based on discussion at #discuss-opensuse slack?

@hellcp
Copy link
Member

hellcp commented Oct 11, 2024

@hellcp what's your recommendation based on discussion at #discuss-opensuse slack?

Think about the structure of data instead of the structure of the site. Can you improve the listing to only include the things that people care about?

@@ -308,6 +311,7 @@ overview: Overview
download: Download
alternative_downloads: Alternative Downloads
alternative_downloads_desc: We also have $options images. Check out $alternative_downloads!
download_server_desc: Still haven't found image you were looking for? Check out <a href="https://download.opensuse.org/distribution/$distro">download server</a>!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either "the" or "our" "download server".

@lkocman
Copy link
Contributor Author

lkocman commented Oct 16, 2024

@hellcp from additional images it would be GNOME+KDE live x86_64-only and minimal images for x86_64, aarch64
From existing ones ... s390x+ppc64le could probably be hidden

@hellcp
Copy link
Member

hellcp commented Oct 16, 2024

Well, it's a matter of moving that into installation images list, and probably renaming them to something more meaningful, and creating a ports list with the rest of the architectures

@omkar200412
Copy link

Can we change our UI of that page?

@hellcp
Copy link
Member

hellcp commented Jan 12, 2025

@omkar200412 what do you have in mind?

@omkar200412
Copy link

@omkar200412 what do you have in mind?

i'll just asked you if we change then better for users and all

@Mexit
Copy link

Mexit commented Feb 13, 2025

@hellcp
Maybe Omkar asks why doing a simple thing like adding missing download links takes so long

#203

@lkocman lkocman requested a review from Copilot April 3, 2025 14:00
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements alternative download layout options for Leap and Tumbleweed while preserving the existing Micro behavior. Key changes include updating the display modes in download configuration files, modifying localization strings for installation media and download server messages, and uncommenting and restructuring the minimal_vm_images and live_images blocks for Leap.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
_data/tumbleweed.yml Changed display values for minimal_vm_images and live_images to "all".
_data/locales/en.yml Updated translation strings and added a new message for the download server.
_data/156.yml Uncommented and restructured download blocks (minimal_vm_images and live_images) for Leap.
Files not reviewed (1)
  • _includes/distribution.html: Language not supported
Comments suppressed due to low confidence (3)

_data/tumbleweed.yml:168

  • Changing the display mode to 'all' deviates from the previous 'server' and 'desktop' values; please verify that this change aligns with the intended single page download layout behavior.
  display: all

_data/locales/en.yml:314

  • Ensure that the use of raw HTML and the variable '$distro' in this translation string is properly handled and secure in the localization system.
download_server_desc: Still haven't found image you were looking for? Check out <a href="https://download.opensuse.org/distribution/$distro">download server</a>!

_data/156.yml:133

  • Confirm that the uncommented and restructured 'minimal_vm_images' block adheres to the expected schema, and that the indentation and configuration changes are consistent with other download blocks.
+ name: minimal_vm_images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants