download_assets: ensure files from obs_scm service are parsed too#1120
Open
fcrozat wants to merge 1 commit intoopenSUSE:masterfrom
Open
download_assets: ensure files from obs_scm service are parsed too#1120fcrozat wants to merge 1 commit intoopenSUSE:masterfrom
fcrozat wants to merge 1 commit intoopenSUSE:masterfrom
Conversation
| for my $file (sort keys %$files) { | ||
| next unless $file eq 'sources' || $file eq 'go.sum' || $file eq 'PKGBUILD' || $file eq 'APKBUILD' || $file eq 'Dockerfile' || $file =~ /^Dockerfile\./ || $file =~ /\.(?:spec|dsc|kiwi)/; | ||
| my $_file_to_match = $file; | ||
| $_file_to_match =~ s/^_service:obs_scm\.// if $_file_to_match =~ /^_service:obs_scm\./; |
Member
There was a problem hiding this comment.
if at all which should block all _service: files and have no specifics to a service implementation.
Question for me is if we should support the mix of (server side) services with assets at all.
The idea is still to replace obs_scm with remote assets instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a Dockerfile is fetched using obs_scm source service, download_assets will ignore the file.
This should fix it.