Fix autocomplete filters showing empty values #18926
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where autocomplete filters (Projects, Packages, Creators, Reviewers, Staging Projects, and Priorities) were showing empty checkboxes after clicking the magnifier button to submit a search.
Problem
When using autocomplete filters on the requests page:
This happened because when the form was submitted, empty string values were being added to the params array and stored in
@selected_filterwithout being cleaned up.Solution
Modified
Webui::RequestsFilterconcern to use.compact_blankwhen assigning filter parameters to@selected_filter, ensuring empty strings are removed before rendering checkboxes in the view.Changed methods:
filter_creatorsfilter_prioritiesfilter_staging_projectsfilter_reviewersfilter_project_namesfilter_package_namesThis brings all filter methods in line with the
filter_labelsmethod, which was already correctly usingcompact_blank.Testing
Added comprehensive tests in
spec/controllers/webui/users/bs_requests_controller_spec.rbto verify:@selected_filterhash doesn't contain empty stringsVerification Steps
/my/requests)Files Changed
app/controllers/concerns/webui/requests_filter.rb- Added.compact_blankto 6 filter methodsspec/controllers/webui/users/bs_requests_controller_spec.rb- Added tests for empty value handlingRelated Issues
Fixes #18826