Skip to content

Link to the report from a report notification #18965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
krauselukas wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −33
Draft

Link to the report from a report notification #18965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 4 additions & 33 deletions src/api/app/models/notification_report.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,21 +58,12 @@ def link_text
# https://trello.com/c/xrjOZGa7/45-ensure-all-reports-of-a-decision-point-to-the-same-reportable
# This reportable won't be nil once we fix this: https://trello.com/c/vPDiLjIQ/66-prevent-the-creation-of-reports-without-reportable
def link_path
case event_type
when 'Event::ReportForComment'
# Do not have a link for deleted comments
Comment.exists?(event_payload['reportable_id']) && path_to_commentables_on_reports(event_payload: event_payload, notification_id: id)
when 'Event::ReportForProject', 'Event::ReportForPackage'
event_type.constantize.notification_link_path(self)
when 'Event::ReportForUser'
Rails.application.routes.url_helpers.user_path(accused, notification_id: id) if !accused.deleted? || User.session!.admin?
when 'Event::ReportForRequest'
bs_request = notifiable.reportable
Rails.application.routes.url_helpers.request_show_path(bs_request.number, notification_id: id)
when 'Event::ClearedDecision', 'Event::FavoredDecision'
if event_type.starts_with?('Event::ReportFor')
Rails.application.routes.url_helpers.report_path(event_payload['id'])
elsif event_type == 'Event::ClearedDecision' || 'Event::FavoredDecision'
reportable = notifiable.reports.first.reportable
link_for_reportables(reportable)
when 'Event::AppealCreated'
elsif event_type == 'Event::AppealCreated'
Rails.application.routes.url_helpers.appeal_path(notifiable, notification_id: id)
end
end
Expand Down Expand Up @@ -114,26 +105,6 @@ def link_for_commentables_on_reportables(commentable:)
Rails.application.routes.url_helpers.project_show_path(commentable, notification_id: id, anchor: 'comments-list')
end
end

def path_to_commentables_on_reports(event_payload:, notification_id:)
case event_payload['commentable_type']
when 'BsRequest'
Rails.application.routes.url_helpers.request_show_path(event_payload['bs_request_number'],
notification_id: notification_id, anchor: 'comments-list')
when 'BsRequestAction'
Rails.application.routes.url_helpers.request_show_path(number: event_payload['bs_request_number'],
request_action_id: event_payload['bs_request_action_id'],
notification_id: notification_id, anchor: 'tab-pane-changes')
when 'Package'
Rails.application.routes.url_helpers.package_show_path(package: event_payload['package_name'],
project: event_payload['project_name'],
notification_id: notification_id,
anchor: 'comments-list')
when 'Project'
Rails.application.routes.url_helpers.project_show_path(event_payload['project_name'], notification_id: notification_id,
anchor: 'comments-list')
end
end
end

# == Schema Information
Expand Down