Skip to content

Conversation

@dmach
Copy link
Contributor

@dmach dmach commented Oct 6, 2023

No description provided.

@pep8speaks
Copy link

pep8speaks commented Oct 6, 2023

Hello @dmach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 5162:121: E501 line too long (140 > 120 characters)
Line 5183:121: E501 line too long (123 > 120 characters)

Line 216:121: E501 line too long (137 > 120 characters)

Line 5:1: E302 expected 2 blank lines, found 1

Comment last updated at 2025-01-07 08:51:16 UTC

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.26%. Comparing base (c8ee1c6) to head (879eb2d).
Report is 91 commits behind head on master.

❗ Current head 879eb2d differs from pull request most recent head c1fb29c. Consider uploading reports for the commit c1fb29c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1424      +/-   ##
==========================================
- Coverage   31.47%   31.26%   -0.21%     
==========================================
  Files         103       49      -54     
  Lines       19070    17820    -1250     
==========================================
- Hits         6002     5572     -430     
+ Misses      13068    12248     -820     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmach dmach force-pushed the typeguard branch 6 times, most recently from 53d81f0 to 34731ee Compare October 11, 2023 09:57
@dmach dmach force-pushed the typeguard branch 4 times, most recently from 6cbad76 to 21e78e0 Compare October 17, 2023 17:18
%endif

# use typeguard during build on distros where typeguard is available
%if (0%{?suse_version} > 1500 || 0%{?fedora} >= 37)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have to care about Fedora 36 and older

Suggested change
%if (0%{?suse_version} > 1500 || 0%{?fedora} >= 37)
%if (0%{?suse_version} > 1500 || 0%{?fedora})

It is also possible to use typeguard in osc-wrapper.py
by setting OSC_TYPEGUARD=1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants