-
Notifications
You must be signed in to change notification settings - Fork 198
Add git-obs init command #1864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add git-obs init command #1864
Conversation
772f4f4 to
6a18bbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed the first review, I suppose I'll have more questions later.
We definitely need to clarify the overall design, it doesn't seem to be complete to me.
| if general: | ||
| res = general.get("git_obs_repo_init_template") | ||
|
|
||
| for i in data.get("logins", []): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This duplicates get_login().
Couldn't we simplify it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only "duplicate" part is a loop over login entries and I don't think about any simplification that can replace a simple loop. E.g. adding an abstraction function with a callback instead of simple loop is not much simpler.
93aca9c to
527cef9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1864 +/- ##
==========================================
- Coverage 34.53% 34.15% -0.39%
==========================================
Files 167 173 +6
Lines 23343 24054 +711
==========================================
+ Hits 8062 8216 +154
- Misses 15281 15838 +557 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
527cef9 to
cb7c4fe
Compare
|
I've force-pushed rebased PR with conflicts resolved. |
No description provided.