Skip to content

Conversation

@andrii-suse
Copy link
Collaborator

No description provided.

@andrii-suse andrii-suse mentioned this pull request Jul 9, 2025
@andrii-suse andrii-suse force-pushed the git_obs_init branch 4 times, most recently from 772f4f4 to 6a18bbf Compare July 14, 2025 11:38
Copy link
Contributor

@dmach dmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed the first review, I suppose I'll have more questions later.
We definitely need to clarify the overall design, it doesn't seem to be complete to me.

if general:
res = general.get("git_obs_repo_init_template")

for i in data.get("logins", []):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This duplicates get_login().
Couldn't we simplify it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only "duplicate" part is a loop over login entries and I don't think about any simplification that can replace a simple loop. E.g. adding an abstraction function with a callback instead of simple loop is not much simpler.

@andrii-suse andrii-suse force-pushed the git_obs_init branch 4 times, most recently from 93aca9c to 527cef9 Compare July 28, 2025 08:38
@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 14.53488% with 147 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.15%. Comparing base (06bc3f2) to head (527cef9).
⚠️ Report is 87 commits behind head on master.

Files with missing lines Patch % Lines
osc/commands_git/repo_init.py 0.00% 62 Missing ⚠️
osc/git_scm/store.py 35.41% 31 Missing ⚠️
osc/util/file_utils.py 0.00% 23 Missing ⚠️
osc/gitea_api/conf.py 4.54% 21 Missing ⚠️
osc/gitea_api/repo.py 0.00% 7 Missing ⚠️
osc/gitea_api/git.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1864      +/-   ##
==========================================
- Coverage   34.53%   34.15%   -0.39%     
==========================================
  Files         167      173       +6     
  Lines       23343    24054     +711     
==========================================
+ Hits         8062     8216     +154     
- Misses      15281    15838     +557     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmach
Copy link
Contributor

dmach commented Oct 14, 2025

I've force-pushed rebased PR with conflicts resolved.
The tests are still failing, because the used git repos are not valid Git SCM checkouts.
We either need to set apiurl, project and package or change how git-obs repo init interacts with the underlying git.
I'll look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants