Avoid 500 when event type length is blank - #3791
Open
officialasishkumar wants to merge 1 commit into
Open
Conversation
The `length_step` validator runs unconditionally for every record and calls `length % program.schedule_interval`. When the length field is left blank in the admin form, `length` is nil and `length %` raises NoMethodError, returning a 500 Internal Server Error instead of a regular validation failure. Skip the divisor check unless `length` is numeric so that the `numericality` validator on `:length` can produce a proper error message, restoring the usual validation feedback.
hennevogel
requested changes
Jun 16, 2026
| # | ||
| def length_step | ||
| errors.add(:length, "must be a divisor of #{program.schedule_interval}") if program && length % program.schedule_interval != 0 | ||
| return unless program && length.is_a?(Numeric) |
Member
There was a problem hiding this comment.
This is a validation for Program and possibly a data migration making sure existing data is Numeric.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Short description of what this resolves/which issues does this fix?:
Changes proposed in this pull request: