Fix: event commercial permissions in non-admin flow - #3803
Merged
Conversation
Non-admin proposal flow uses Ability, not AdminAbility, so organizers and CFP users could edit proposals but could not create event commercials. Closes openSUSE#3143. Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
RedZapdos123
marked this pull request as ready for review
May 31, 2026 15:56
RedZapdos123
changed the title
hennevogel
requested changes
Jun 16, 2026
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
hennevogel
approved these changes
Jun 18, 2026
Member
|
What does the last commit have to do with this PR? |
RedZapdos123
force-pushed
the
fix-commercial-auth
branch
from
June 18, 2026 13:12
dc4a79d to
de4400a
Compare
Member
|
@RedZapdos123 thanks Mridankan :) |
Contributor
Author
Yes, it was out of scope for this PR, so I had reverted it. I had added it to address a failing spec/features/proposals_spec.rb check on this branch, where Selenium hit a stale node error during proposal confirmation. I moved that commit's changes for test stabilization to #3808 (based on issue #3807). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Issue #3143 reported that organizers could edit a proposal in the non-admin flow but hit
AccessDeniedwhen creating a commercial for that proposal.This PR updates
Abilityso organizers and CFP team members can manage event commercials for conferences where they already have proposal-management access in non-admin views.It also adds regression tests that cover the relevant ability rules.
Closes #3143.
Checklist:
bundle exec rubocop app/models/ability.rb spec/ability/ability_spec.rb.bundle exec rspec spec/ability/ability_spec.rb.Additional validation:
bundle exec rake spec:abilityin WSL.Before the fix (when signed in as an organizer):
After the fix (when signed in as an organizer):