PART 13: Use simpler mocking+more checks - After #319 #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
force-pushed
the
feature/coverage17
branch
from
014f5bb to
e510492
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #321 +/- ##
==========================================
- Coverage 94.09% 94.01% -0.08%
==========================================
Files 51 51
Lines 4808 4747 -61
Branches 302 301 -1
==========================================
- Hits 4524 4463 -61
Misses 202 202
Partials 82 82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Fixed the branch coverage regression in openqabot/main.py and added three commits |
kalikiana
approved these changes
Dec 12, 2025
okurz
force-pushed
the
feature/coverage17
branch
2 times, most recently
from
c98c81a to
6c3bbe8
Compare
Wabri
approved these changes
Dec 12, 2025
Wabri
requested changes
Dec 12, 2025
Member
Wabri
left a comment
Wabri
left a comment
There was a problem hiding this comment.
Wrong checkbox clicked on the previous review
Martchus
requested changes
Dec 12, 2025
Martchus
requested changes
Dec 12, 2025
okurz
force-pushed
the
feature/coverage17
branch
2 times, most recently
from
db8fa3e to
6448585
Compare
caplog.messages is a method added in Python 3.7 simplifying our repeated use of `messages = [x[-1] for x in caplog.record_tuples]`
…of abused parametrize
…om decorator "with_fake_qem"
…ssages caplog.messages is a method added in Python 3.7 simplifying our code.
okurz
force-pushed
the
feature/coverage17
branch
2 times, most recently
from
be06bdb to
d6079aa
Compare
Member
Author
|
@Wabri please re-review. I tried to address your points. @Martchus all your points addressed except for the open discussion #321 (comment) |
Martchus
approved these changes
Dec 15, 2025
…l-mb/python-refactoring-skills This adds targets for additional code quality checks that seem to be not covered by ruff, i.e. maintainability check and duplication checks. complexity is already covered by C901. "radon" only outputs violations. The Python package "xenon" would call radon and fail if violations found but the package is not available in openSUSE so I was implementing a very simple check with inverted grep for "any output".
…fo to use patch fixture
…r and fix imports
…syncres.py Replaced pytest.MonkeyPatch with unittest.mock.patch for mocking in tests/test_incsyncres.py.
…st_openqabot_simple.py Replaced pytest.MonkeyPatch with unittest.mock.patch for mocking in tests/test_openqabot_simple.py.
…elper.py Replaced pytest.MonkeyPatch with unittest.mock.patch for mocking in tests/test_pc_helper.py.
…tsync.py Replaced pytest.MonkeyPatch with unittest.mock.patch for mocking in tests/test_smeltsync.py.
…tch context manager
…ch context manager
…atch context manager
…instead of patch context manager
This prevents a confusing log message like ``` Unable to load config file '/etc/openqabot/singlearch.yml': 'list' object has no attribute 'get' ```
okurz
force-pushed
the
feature/coverage17
branch
from
d6079aa to
78fd366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After: