refactor: use params for all other URL constructions#482
Merged
mergify[bot] merged 1 commit intoopenSUSE:masterfrom Apr 20, 2026
Merged
Conversation
okurz
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #482 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 97 97
Lines 9690 9690
Branches 514 514
=========================================
Hits 9690 9690 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
okurz
force-pushed
the
feature/use_proper_url_building_with_params
branch
4 times, most recently
from
4395e26 to
19b0972
Compare
okurz
changed the title
Motivation: Consistently use the 'params' argument for URL query parameters across the codebase to avoid manual string manipulation and ensure proper encoding. Design Choices: - Refactored `get_json` and `get_json_list` in `openqabot/loader/gitea.py` to support `params` and updated callers. - Updated `get_aggregate_settings_data` in `openqabot/loader/qem.py` to pass parameters via `params`. - Refactored `get_older_jobs` in `openqabot/openqa.py` to use positional arguments for params as expected by `openqa_client`. - Updated relevant test mocks in `tests/test_giteasync.py` and `tests/test_loader_qem.py`. Benefits: - Code consistency and readability. - Robust handling of query parameters across different modules. Related issue: openSUSE#480
okurz
force-pushed
the
feature/use_proper_url_building_with_params
branch
from
19b0972 to
5cfe77d
Compare
d3flex
approved these changes
Apr 20, 2026
Contributor
|
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Consistently use the 'params' argument for URL query parameters
across the codebase to avoid manual string manipulation and ensure
proper encoding.
Design Choices:
get_jsonandget_json_listinopenqabot/loader/gitea.pyto support
paramsand updated callers.get_aggregate_settings_datainopenqabot/loader/qem.pytopass parameters via
params.get_older_jobsinopenqabot/openqa.pyto use positionalarguments for params as expected by
openqa_client.tests/test_giteasync.pyandtests/test_loader_qem.py.Benefits: