Proof of Concept: Post a comment #92
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
force-pushed
the
post-osc-comment
branch
from
3f3dfc5 to
d997622
Compare
perlpunk
force-pushed
the
post-osc-comment
branch
from
d997622 to
3eea184
Compare
Contributor
Author
|
rebased and added a small (still commented) test. |
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
2 similar comments
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://progress.opensuse.org/issues/114415
Usage:
To post an actual comment, remove the
--dry, but beware that you might also approve the incident.I think using the
Commenterinterface doesn't make much sense, as it currently expects a namespace argument for its constructor.But if we are never going to use the comment subcommand, then we can rewrite the Commenter interface, of course.