Refactor compile_junos_data #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacerus
added
the
juniper_junos-formula
tacerus
force-pushed
the
refactor/juniper_junos/compile
branch
2 times, most recently
from
c4495d0 to
6f02512
Compare
tacerus
force-pushed
the
refactor/juniper_junos/compile
branch
from
03df3a0 to
58bc16c
Compare
tacerus
force-pushed
the
refactor/juniper_junos/compile
branch
from
ef831c6 to
6509556
Compare
Add ng version of script. Signed-off-by: Georg Pfuetzenreuter <[email protected]> Add file handling to compile_junos_data_ng - Drop backbone.yaml - Read specified input and write to specified output Signed-off-by: Georg Pfuetzenreuter <[email protected]> Update compile_junos_data_ng - use Python 3.11 explicitly - rename "port_group" attribute to "group" - set default interface mode to "access" - drop print statements - drop empty VLAN ID lists from output Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Detect VLANs which are duplicated using names and ID numbers. For example, if "vlan2000" and "2000" are contained in the VLAN IDs of an interface, only keep "2000". Signed-off-by: Georg Pfuetzenreuter <[email protected]>
If no role for a device is present, assume the device to be an access switch. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
- correct nest the "mc" dict underneath "ae", no longer incorrectly write it underneath "lacp" - facilitate trunk interfaces with the "all" VLAN ID, avoid an empty list being written instead Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Do not write a "None" description for VLANs not providing any description in the input data. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
Signed-off-by: Georg Pfuetzenreuter <[email protected]>
tacerus
force-pushed
the
refactor/juniper_junos/compile
branch
2 times, most recently
from
5e0a756 to
9754eda
Compare
Wish I recalled why this was needed. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
- bump copyright year - remove development comments Signed-off-by: Georg Pfuetzenreuter <[email protected]>
tacerus
force-pushed
the
refactor/juniper_junos/compile
branch
from
9754eda to
0fcb358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ng version of script.