Add retention config for snbk - #1179
Open
jameslai-dev wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
retention-policyandretention-configentries to the snbkBackupConfig.The
retention-policysupportsdefaultandcustomoptions. Thedefaultpolicy is designed to keep the snapshots on the backup device identical to those on the source device (the existing behavior); thecustompolicy requires an additional configuration entryretention-config, which defines the cleanup behavior.The parameters under the
retention-configsection share the same names assnapperconfiguration options (NUMBER_LIMIT, TIMELINE_LIMIT_HOURLY, ...), so that the cleanup parameter class (theParametersclass inclient/cleanup.cc) can load the config without a major interface modification.An example config:
{ "config": "test", "target-mode": "local", "target-path": "/mnt/test-btrfs-target/.snapper/data", "automatic": false, "retention-policy": "custom", "retention-config": { "NUMBER_MIN_AGE": "3600", "NUMBER_LIMIT": "50", "NUMBER_LIMIT_IMPORTANT": "10", "TIMELINE_MIN_AGE": "3600", "TIMELINE_LIMIT_HOURLY": "48", "TIMELINE_LIMIT_DAILY": "14", "TIMELINE_LIMIT_WEEKLY": "12", } }Additional changes:
get_child_valuefunction is added to theJsonFilemodule to support parsing a JSON node into a string-to-string dictionary.Things to discuss:
Parent issue: #1105