Skip to content

Conversation

@agentfarmx
Copy link
Contributor

@agentfarmx agentfarmx bot commented Mar 12, 2025

agent_instance: openSVM_osvm-cli_issue_14_0ff5b03f Tries to fix: #14

πŸ› οΈ Fix: Resolved code formatting issues

This PR fixes syntax and formatting issues by addressing:

  • Fixed: Missing closing parenthesis in clparse.rs
  • Fixed: Removed trailing whitespace in examples.rs at lines 89, 114, 183, and 245
  • Fixed: Added proper newlines at end of files to meet Rust formatting standards

All formatting issues have been resolved, and cargo fmt --all -- --check now runs without any errors.

Summary by Sourcery

Fix code formatting issues, including missing parentheses, trailing whitespace, and missing newlines at the end of files.

Bug Fixes:

  • Fix missing closing parenthesis in clparse.rs.
  • Remove trailing whitespace in examples.rs at lines 89, 114, 183, and 245.
  • Add proper newlines at end of files to meet Rust formatting standards.

@agentfarmx agentfarmx bot mentioned this pull request Mar 12, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 12, 2025

Reviewer's Guide by Sourcery

This PR addresses code formatting issues across the project, including fixing missing parentheses, removing trailing whitespace, and adding proper newlines to meet Rust formatting standards. The changes enhance code readability and consistency.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Refactored code for better readability and consistency.
  • Added newlines for better code formatting.
  • Removed trailing whitespace.
  • Aligned code for better readability.
src/utils/svm_info.rs
src/utils/nodes.rs
src/main.rs
src/utils/nodes_dashboard.rs
src/utils/ssh_deploy/client.rs
src/utils/ssh_deploy/tests/unit.rs
src/utils/ssh_deploy/deployments/solana.rs
src/utils/ssh_deploy/tests/e2e.rs
src/utils/dashboard.rs
src/utils/examples.rs
src/utils/ssh_deploy/disk_management.rs
src/utils/ssh_deploy/optimizations.rs
src/utils/ssh_deploy/deployments/s00n.rs
src/utils/ssh_deploy/deploy.rs
src/utils/ssh_deploy/deployments/sonic.rs
src/utils/ssh_deploy/deployments/eclipse.rs
src/utils/ssh_deploy/dependencies.rs
src/utils/ssh_deploy/validators.rs
src/utils/ssh_deploy/hot_swap.rs
src/utils/ssh_deploy/monitoring.rs
tests/e2e/svm_tests.rs
src/utils/ssh_deploy/services.rs
tests/e2e/examples.rs
src/utils/ssh_deploy/types.rs
src/utils/ssh_deploy/mod.rs
tests/e2e/node_tests.rs
src/utils/mod.rs
src/utils/color.rs
tests/e2e/mod.rs
src/clparse.rs
src/prelude.rs
src/utils/ssh_deploy/errors.rs
tests/main.rs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, agentfarmx[bot]!). We assume it knows what it's doing!

@0xrinegade
Copy link
Member

thread 'main' panicked at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/hidapi-1.5.0/build.rs:57:54:
Unable to find libudev:
pkg-config exited with status code 1

PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 pkg-config --libs --cflags libudev

The system library libudev required by crate hidapi was not found.
The file libudev.pc needs to be installed and the PKG_CONFIG_PATH environment variable must contain its parent directory.
The PKG_CONFIG_PATH environment variable is not set.

HINT: if you have installed the library, try setting PKG_CONFIG_PATH to the directory containing libudev.pc.

stack backtrace:
0: rust_begin_unwind
at /rustc/4d91de4e48198da2e33413efdcd9cd2cc0c46688/library/std/src/panicking.rs:692:5
1: core::panicking::panic_fmt
at /rustc/4d91de4e48198da2e33413efdcd9cd2cc0c46688/library/core/src/panicking.rs:75:14
2: core::result::unwrap_failed
at /rustc/4d91de4e48198da2e33413efdcd9cd2cc0c46688/library/core/src/result.rs:1704:5
3: core::result::Result<T,E>::expect
4: build_script_build::compile_linux::{{closure}}
5: <alloc::boxed::Box<F,A> as core::ops::function::Fn>::call
6: build_script_build::compile_linux
7: build_script_build::main
8: core::ops::function::FnOnce::call_once

@agentfarmx
Copy link
Contributor Author

agentfarmx bot commented Mar 12, 2025

βœ… Fixed: Resolved code formatting issues in the repository

  • Fixed: Missing closing parenthesis in clparse.rs that was causing syntax errors
  • Fixed: Added proper newlines at end of files to meet Rust formatting standards
  • Added: Documentation about the libudev system dependency for developers

The changes ensure that cargo fmt --check now runs without any errors, maintaining code quality standards. The PR also provides guidance on resolving the system dependency issue with libudev that appears during compilation.

@0xrinegade 0xrinegade merged commit fc03f91 into main Mar 12, 2025
4 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix fmt

2 participants