Fix type definition for responses in ClientFake::addResponses method#382
Merged
iBotPeaches merged 3 commits intoopenai-php:mainfrom Apr 7, 2025
Merged
Fix type definition for responses in ClientFake::addResponses method#382iBotPeaches merged 3 commits intoopenai-php:mainfrom
iBotPeaches merged 3 commits intoopenai-php:mainfrom
Conversation
|
any update on when this fix can be expected to be merged? |
Contributor
Author
|
Fix #513 |
iBotPeaches
approved these changes
Apr 5, 2025
iBotPeaches
requested changes
Apr 5, 2025
Collaborator
iBotPeaches
left a comment
iBotPeaches
left a comment
There was a problem hiding this comment.
Apologies. I was going to merge this, but it fails composer test:lint.
iBotPeaches
approved these changes
Apr 7, 2025
Collaborator
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
Fix type definition in
ClientFake::addResposnses()method to avoid messages from IDE advertising thhat objects passed are of different type