Fix ramp halt timing and add ramp window coverage - #26
Merged
hemanth-asirvatham merged 1 commit intoFeb 7, 2026
Merged
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
_halt_ramp_up()from taking effect after the ramp window by returning early whentime.time() >= ramp_up_end_time._halt_ramp_up()from worker error handlers on first observed rate-limit or connection errors to lock the ramp while it is still active._maybe_emit_ramp_complete()(and call it from the embeddings worker loop) to log/print a ramp-complete message when the ramp window elapses.rate_limit_errorsandconnection_errorsinemit_parallelization_status()and track/resetrate_limit_errors_since_last_statusin the reporter loop.message_verboseis enabled.test_ramp_up_halts_on_rate_limitassert that a halting message is printed and addtest_ramp_up_does_not_halt_after_windowto verify that a late error (after the ramp window) does not halt the ramp.Testing
python -m pytest tests/test_parallelization_tuning.py, and all tests passed (8 passed in 4.52s).Codex Task