Skip to content

Propagate response_fn / get_all_responses_fn through Discover pipeline - #7

Merged
hemanth-asirvatham merged 1 commit into
mainfrom
verify-implementation-of-response-functions
Feb 6, 2026
Merged

Propagate response_fn / get_all_responses_fn through Discover pipeline#7
hemanth-asirvatham merged 1 commit into
mainfrom
verify-implementation-of-response-functions

Conversation

@hemanth-asirvatham

Copy link
Copy Markdown
Collaborator

Motivation

  • Ensure custom per-prompt or driver overrides (response_fn / get_all_responses_fn and other runtime kwargs) passed into Discover.run actually reach the downstream stages (Codify, Compare, Bucket, Classify) so custom handlers are honored end-to-end.
  • Note: the core helper get_all_responses already implements precedence, validation and behavior for custom drivers and response functions, so the pipeline should forward the kwargs rather than swallow them.

Description

  • Forward **kwargs from Discover.run into internal stage calls by adding **kwargs when calling coder.run, cmp.run, buck.run, clf.run in src/gabriel/tasks/discover.py so options such as response_fn and get_all_responses_fn are propagated.
  • No change to get_all_responses itself; it continues to validate custom drivers (requires prompts/identifiers) and to make get_all_responses_fn take precedence over response_fn when both are supplied.
  • Small, targeted change confined to src/gabriel/tasks/discover.py to unblock end-to-end custom response overrides.

Testing

  • No automated tests were executed for this change.

Codex Task

@github-actions

github-actions Bot commented Feb 6, 2026

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@hemanth-asirvatham
hemanth-asirvatham merged commit bed11af into main Feb 6, 2026
1 check failed
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant