Propagate callable overrides to ideate deduplication and avoid duplicate response_fn/get_all_responses_fn in whatever - #8
Merged
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
response_fn/get_all_responses_fn) are consistently forwarded into the ideation deduplication step so user-provided overrides are honored.response_fn/get_all_responses_fnentries into nested runner invocations which caused "multiple values for keyword argument" errors.Description
deduplicate_run_kwargsparameter to the top-levelideateAPI and included it in the_with_callable_overridesplumbing soresponse_fn/get_all_responses_fnpropagate into the ideation deduplication run (updatedsrc/gabriel/api.py).deduplicate_run_kwargstoIdeate.runso nested deduplication receives those run-time overrides (updated call-site inideate).whateverhelper to consume anyresponse_fn/get_all_responses_fnfrom**kwargswhen the explicit parameters are not provided, and to remove them fromkwargsif the explicit parameters are set, preventing duplicate keyword passing to nestedrunner.run(updatedsrc/gabriel/api.py).ideatedocstring to mention deduplicate overrides in the list of fine-grained_run_kwargs.Testing
src/gabriel/api.pyand require integration/runtime verification with user callables.Codex Task