tests(js_repl): stabilize CI runtime test execution#12407
Open
tests(js_repl): stabilize CI runtime test execution#12407
Conversation
This was referenced Feb 21, 2026
c64d1c1 to
f26ef7a
Compare
bolinfest
reviewed
Feb 21, 2026
| filter = 'test(approval_matrix_covers_all_modes)' | ||
| slow-timeout = { period = "30s", terminate-after = 2 } | ||
|
|
||
| [[profile.default.overrides]] |
Collaborator
There was a problem hiding this comment.
I did not know about this config file! Clearly I missed #6612.
cec24cc to
6757420
Compare
bolinfest
reviewed
Feb 21, 2026
6757420 to
daaafaf
Compare
git-stack-id: fjord/js_repl_seq---4htl2cund94dlu git-stack-title: tests(js_repl): stabilize CI runtime test execution
daaafaf to
f3b0175
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilize
js_replruntime test execution in CI and move tool-facingjs_replbehavior coverage into the integration test suite.This is a test/CI change only; no production
js_replbehavior change is intended.Why
nodethan the one installed byactions/setup-node, causingjs_replruntime/version failures.js_replruntime tests can be flaky on Windows when too many Node kernels cold-start concurrently.js_repltests in the unit-test module were actually black-box/tool-level behavior tests and fit better in the integration suite.Changes
actions/setup-nodeto the Bazel and RustTestsworkflows using the exact version pinned bycodex-rs/node-version.txt(nocheck-latest).CODEX_JS_REPL_NODE_PATH=$(which node)into test env sojs_repluses theactions/setup-noderuntime inside Bazel tests.max-threads = 1forjs_replruntime tests to avoid concurrent Node-kernel startup timeout bursts (includingsuite::js_repl::*and theview_imagejs_replpath).js_repltool behavior incodex-rs/core/tests/suite/js_repl.rsand register it incodex-rs/core/tests/suite/mod.rs.processglobal isolation, blocked builtin imports).codex-rs/core/src/tools/js_repl/mod.rs, with test setup using constrained policy setters andDangerFullAccesswhere sandbox dispatch behavior is not under test.suite::js_repl::*tests when no Node runtime is available.Impact
js_replCI false negatives caused by Node resolution drift and Windows concurrency timeouts.git stack
1tests(js_repl): stabilize CI runtime test execution #124072feat: update Docker image digest to reflect #12205 #123723tests(js_repl): remove node-related skip paths from js_repl tests #121854Add feature-gated js_repl polling flow #10673