Markdown animates in sync #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rz-openai
reviewed
Aug 22, 2025
richtext-ui/src/commonMain/kotlin/com/halilibo/richtext/ui/BlockQuote.kt
Outdated
Show resolved
Hide resolved
richtext-ui/src/commonMain/kotlin/com/halilibo/richtext/ui/MarkdownAnimation.kt
Outdated
Show resolved
Hide resolved
tananaev
reviewed
Aug 25, 2025
Comment on lines
+192
to
197
| val baseModifier = modifier.graphicsLayer { this.alpha = alpha.value } | ||
| val tableModifier = if (columnArrangement is Adaptive) { | ||
| modifier.horizontalScroll(rememberScrollState()) | ||
| baseModifier.horizontalScroll(rememberScrollState()) | ||
| } else { | ||
| modifier | ||
| baseModifier | ||
| } |
Member
There was a problem hiding this comment.
You can probably just do Modifier.then here
tananaev
approved these changes
Aug 25, 2025
rz-openai
reviewed
Aug 25, 2025
richtext-ui/src/commonMain/kotlin/com/halilibo/richtext/ui/CodeBlock.kt
Outdated
Show resolved
Hide resolved
richtext-ui/src/commonMain/kotlin/com/halilibo/richtext/ui/HorizontalRule.kt
Outdated
Show resolved
Hide resolved
richtext-ui/src/commonMain/kotlin/com/halilibo/richtext/ui/MarkdownAnimation.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A redo of #42 separating out some of the phrase changes I made. The key was to make sure we launch everything in the shared coroutineScope to queue all the elements properly
Screen_recording_20250822_132709.webm