Add an option for only rendering visible text #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rz-openai
reviewed
Oct 10, 2025
richtext-ui/src/commonMain/kotlin/com/halilibo/richtext/ui/string/Text.kt
Outdated
Show resolved
Hide resolved
richtext-ui/src/commonMain/kotlin/com/halilibo/richtext/ui/string/RichTextRenderOptions.kt
Show resolved
Hide resolved
This improves the text animation. Without this, appending two lines will instantly make the `Text` composable jump in height, even though the text isn't visible. With this change you can enable only rendering visible text making the animation much smoother.
ansman
force-pushed
the
nicklas/hide-invisible-text
branch
from
eb58fc2 to
1913535
Compare
rjmarsan
approved these changes
Oct 10, 2025
rjmarsan
left a comment
rjmarsan
left a comment
There was a problem hiding this comment.
looks clean all-in-all. worth trying out.
rz-openai
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the text animation. Without this, appending two lines will instantly make the
Textcomposable jump in height, even though the text isn't visible. With this change you can enable only rendering visible text making the animation much smoother.