fix: bound Action bundle manifest validation - #170
Merged
GrantBirki merged 3 commits intoAug 18, 2026
Conversation
GrantBirki
approved these changes
Aug 18, 2026
GrantBirki
left a comment
Member
There was a problem hiding this comment.
The packaging limit now matches the Action runtime, and the regression test covers oversized manifests. Looks good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the release-side Action bundle validator enforce the same 16 KiB manifest bound as the Action runtime.
Problem
The protected Action runtime reads
bundle-manifest.jsonthroughreadJsonBounded(..., 16 * 1024, ...), so a distribution manifest larger than 16 KiB is rejected before the Action can start.script/validate-action-bundle, which is used to validate assembled/release bundle state, checks the manifest's structure and fields but currently reads it with an unboundedread_text. A manifest can therefore pass packaging validation and still be unusable by the runtime.Evidence / reproduction
action/lib.cts::validateBundlereads the bundle manifest with an explicit 16 KiB bound.script/validate-action-bundlevalidates the sameaction/bundle-manifest.jsoncontract but on the base commit has no corresponding size check beforejson.loads(manifest_path.read_text(...)).json.loadsstill parses that document to exactly the same object, so the base release-side validator accepts it.validateBundlecan complete.This closes a validator/runtime contract gap rather than introducing a new limit.
Change
bundle-manifest.jsonto be non-empty and at most 16 KiB inscript/validate-action-bundleNo manifest schema, release metadata, binary, or Action runtime behavior changes.