fix: stage retained-tool refreshes before publication - #174
Open
sylvesterkaczmarek wants to merge 7 commits into
Open
fix: stage retained-tool refreshes before publication#174sylvesterkaczmarek wants to merge 7 commits into
sylvesterkaczmarek wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the online retained test-tool and release-tool refresh paths build and verify a complete staged tree before replacing the currently valid committed tool tree.
Problem
Both
script/vendor-test-toolsandscript/vendor-release-toolscurrently remove their existing committed artifact directory near the start of the refresh, before the network-dependent work has completed.That means a transient fetch failure, checksum mismatch, archive validation failure, or
cargo vendorfailure can leave the working tree with the previously valid retained tools deleted or only partially rebuilt.This is different from Fence's safer dependency-update pattern, where replacement data is prepared in a temporary location before the existing generated state is replaced.
Evidence / reproduction
script/vendor-test-toolscreates its temporary directory and then immediately callsremove_generated_path "$test_tools_dir"before fetching either licence file or any of the fourcargo-llvm-covarchives.script/vendor-release-toolssimilarly removesvendor/release-toolsbefore fetching the four Zig archives, thecargo-zigbuildcrate, generating its lockfile, or vendoring its dependencies.script/test-staged-treecovers successful publication, validation failure with a previous tree, restoration of the previous bytes, failure-status propagation, and validation failure when no prior tree existed.Change
validate-test-tools/validate-release-toolscheck after publicationscript/testentrypointNo retained tool versions, lockfiles, source URLs, checksums, archive formats, or successful refresh outputs change.